[vlc-devel] [PATCH 1/6] decoder: allow the buffer_new from the decoder to be NULL

Rémi Denis-Courmont remi at remlab.net
Tue Jun 25 18:30:38 CEST 2019


Le tiistaina 25. kesäkuuta 2019, 16.55.21 EEST Thomas Guillem a écrit :
> On Tue, Jun 25, 2019, at 15:03, Rémi Denis-Courmont wrote:
> > Hi,
> > 
> > Ok given that it does not change the current behaviour. But I don't think
> > picture_NewFromFormat() will be a suitable default. In general allocating
> > and freeing a picture every time is too slow, so we will need some sort
> > of pool per decoder.
> For info, on linux, on my desktop, it's faster to allocate a 4K picture each
> time rather than locking/getting/unlocking from a pool. But I guess results
> are different on many OSes.

Then close #22471 as invalid.

But even if modern OSes make allocations fast enough, a pool might still be 
needed for rate limitting.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the vlc-devel mailing list