[vlc-devel] [PATCH 1/6] decoder: allow the buffer_new from the decoder to be NULL

Thomas Guillem thomas at gllm.fr
Tue Jun 25 20:11:33 CEST 2019



On Tue, Jun 25, 2019, at 18:30, Rémi Denis-Courmont wrote:
> Le tiistaina 25. kesäkuuta 2019, 16.55.21 EEST Thomas Guillem a écrit :
> > On Tue, Jun 25, 2019, at 15:03, Rémi Denis-Courmont wrote:
> > > Hi,
> > > 
> > > Ok given that it does not change the current behaviour. But I don't think
> > > picture_NewFromFormat() will be a suitable default. In general allocating
> > > and freeing a picture every time is too slow, so we will need some sort
> > > of pool per decoder.
> > For info, on linux, on my desktop, it's faster to allocate a 4K picture each
> > time rather than locking/getting/unlocking from a pool. But I guess results
> > are different on many OSes.
> 
> Then close #22471 as invalid.
> 
> But even if modern OSes make allocations fast enough, a pool might still be 
> needed for rate limitting.

And I guess it's not as fast when you don't have a lot of memory or when it is segmented. 

> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list