[vlc-devel] [RFC PATCH 1/5] filter: add a way to signal error from callbacks

[Thomas Guillem]

On Fri, Mar 1, 2019, at 13:39, Rémi Denis-Courmont wrote:
> Hi,
> 
> I do not know why a separate block is needed as opposed to flagging a discontinuity on the following successfully output block.

I will investigate that approach but it feels more complicated. I must make sure the flag is not lost in the filter chain. Should I check in every modules or handle it in the pipeline (aout/filters.c) ?

> 
> But assuming that you have a good reason in mind, there are still some challenges with the error block approach:
> - If it needs to be queued, it needs to be writable, and thus it needs to be allocated, and thus its allocation can fail.

It won't, I put asserts in queue/release/realloc functions. 

> - There are code paths that discards zero-size blocks specially, or fails to handle them at all.
> - Some craptastic platforms might not support exported globals, only functions (not that I'd care personally).
Indeed. 

> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190301/1b1a7aa3/attachment.html>