[vlc-devel] [RFC PATCH 1/5] filter: add a way to signal error from callbacks

Thomas Guillem thomas at gllm.fr
Mon Mar 4 12:23:41 CET 2019

On Fri, Mar 1, 2019, at 13:39, Rémi Denis-Courmont wrote:
> Hi,
> I do not know why a separate block is needed as opposed to flagging a discontinuity on the following successfully output block.

Finally, I prefer that approach (flagging a discontinuity on the following successfully output block).
cf. new patches on the ML.

> But assuming that you have a good reason in mind, there are still some challenges with the error block approach:
> - If it needs to be queued, it needs to be writable, and thus it needs to be allocated, and thus its allocation can fail.
> - There are code paths that discards zero-size blocks specially, or fails to handle them at all.
> - Some craptastic platforms might not support exported globals, only functions (not that I'd care personally).
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190304/1da80ba0/attachment.html>

More information about the vlc-devel mailing list