[vlc-devel] [PATCH V2 1/4] block: add vlc_block_discontinuity
Denis Charmet
typx at videolan.org
Fri Mar 1 14:20:35 CET 2019
Hi,
I can't say I agree with this whole patchset (especially since I'm
killing block_t).
First this lacks protection against all the other blocks functions with
block_Check being flagged. Not having callbacks on it is kinda
dangerous. Especially with fields like p_next available to anyone and
not necessarily via blockChain APIs.
I understand the need but would rather have it passed as a parameter of
pf_filter rather than a special type of block.
Regards,
--
Denis Charmet - TypX
More information about the vlc-devel
mailing list