[vlc-devel] [PATCH V2 1/4] block: add vlc_block_discontinuity

Thomas Guillem thomas at gllm.fr
Sat Mar 2 07:17:06 CET 2019

On Fri, Mar 1, 2019, at 22:57, Denis Charmet wrote:
> Hi,
> I can't say I agree with this whole patchset (especially since I'm 
> killing block_t).

Don't worry, our 2 branches will conflict *a lot* anyway ;) I can take care of resolving conflits. 

> First this lacks protection against all the other blocks functions with 
> block_Check being flagged. Not having callbacks on it is kinda 
> dangerous. Especially with fields like p_next available to anyone and 
> not necessarily via blockChain APIs.
> I understand the need but would rather have it passed as a parameter of 
> pf_filter rather than a special type of block

That is a solution I already think about. The following change is fine with me too:
block_t* pf_audio_filter(filter *, bool *discontinuity);

Do you agree ?

> Regards,
> -- 
> Denis Charmet - TypX
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list