[vlc-devel] [PATCH] Fixes ##21595: fixed creation of cache directory if it does not exist

[Remi Denis-Courmont]

Le 2019-03-10 07:39, Aakash Singh a écrit :
> Hey Remi
> 
> I dont't think a cache directory which does not exist is of much use.

And I don't think mismatched semantics between C and Lua API is a good 
idea.

> So whenever some lua extension asks for the cache directory it is made
> sure that it already exists.

That's a very arbitrary rule for which I fail to see a rationale.

A cache directory without write permission or to a full partition is not 
"of much use", and yet you don't handle that. A cache directory that is 
world-readable or worse, word-writable is outright harmful, and you 
don't handle that either.

> The problem regarding parent directory
> not existing, I went through dirs.c for different operating systems
> and they all return paths with cache directory being child directory
> of some directory created by the system by default.

I don't think that's true. Linux does not create .cache by default, that 
I'd know of.

-- 
Rémi Denis-Courmont