[vlc-devel] [PATCH] Fixes ##21595: fixed creation of cache directory if it does not exist

Aakash Singh 17aakashsingh1999 at gmail.com
Sun Mar 10 17:06:23 CET 2019


I understand you point. So, in order to resolve the issue if I shift the
cache creation to the vlsub itself, will it be ok then?

On Sun, 10 Mar 2019, 21:29 Remi Denis-Courmont, <remi at remlab.net> wrote:

> Le 2019-03-10 07:39, Aakash Singh a écrit :
> > Hey Remi
> >
> > I dont't think a cache directory which does not exist is of much use.
>
> And I don't think mismatched semantics between C and Lua API is a good
> idea.
>
> > So whenever some lua extension asks for the cache directory it is made
> > sure that it already exists.
>
> That's a very arbitrary rule for which I fail to see a rationale.
>
> A cache directory without write permission or to a full partition is not
> "of much use", and yet you don't handle that. A cache directory that is
> world-readable or worse, word-writable is outright harmful, and you
> don't handle that either.
>
> > The problem regarding parent directory
> > not existing, I went through dirs.c for different operating systems
> > and they all return paths with cache directory being child directory
> > of some directory created by the system by default.
>
> I don't think that's true. Linux does not create .cache by default, that
> I'd know of.
>
> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190310/b60df530/attachment.html>


More information about the vlc-devel mailing list