[vlc-devel] [PATCH] aout: modify module API: make modules non-blocking

[Thomas Guillem]

On Tue, Mar 12, 2019, at 17:46, Rémi Denis-Courmont wrote:
> Le tiistaina 12. maaliskuuta 2019, 12.53.23 EET Thomas Guillem a écrit :
> > I reject myself this API changes since It will work only with PulseAudio,
> 
> Ah? You can implement this in ALSA and OSS at least.
> 
> > that has a way to report more_data and drain from its own thread.
> 
> If there are no ways to report write_room/underflow then you are screwed. 
> Having a thread has nothing to do with it.
> 
> > The new
> > API need to handle other main modules too.
> 
> I fail to see the problem with the proposal.

With this proposal, every modules except PulseAudio will have to create and handle their own thread to signal the core.

I guess it's better to factorize that inside the core.

> 
> > I think the best way to pace the
> > play() from other modules is to return a vlc_tick_t from this function,
> > that will tell the core to wait for a given time.
> 
> That will not work with PulseAudio, ALSA and OSS. None of them tell you how 
> long to wait before writing again.
> 
> Trying that approach is a complete waste of your time.
> 
> -- 
> レミ・デニ-クールモン
> /http://www.remlab.net
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel