[vlc-devel] [PATCH] aout: modify module API: make modules non-blocking

Rémi Denis-Courmont remi at remlab.net
Tue Mar 12 19:00:13 CET 2019


Le tiistaina 12. maaliskuuta 2019, 19.20.42 EET Thomas Guillem a écrit :
> With this proposal, every modules except PulseAudio will have to create and
> handle their own thread to signal the core.
> 
> I guess it's better to factorize that inside the core.

Either you make Play asynchronous, and that means everybody will need a 
thread. Or you keep Play blocking/synchronous and you allow concurrency with 
other calls (Flush, Pause, Volume, Mute, DeviceSelect at least).

Either way, it's going to be a respective sort of PITA. I don't think it's 
needed now. But I don't think it can be avoided in 5.0 timeline.

I don't have the benefit of hindsight and I don't know which of the two 
approaches is better, but at least the asynchronous approach sounds less 
error-prone than the concurrent approach because it does not expose threading 
to modules.

-- 
レミ・デニ-クールモン
http://www.remlab.net/





More information about the vlc-devel mailing list