[vlc-devel] [PATCH 3/3] qt: remove no longer used hold/release

[Thomas Guillem]

But if it prevents you to finally cleanup vlc object release, maybe you can merge but this set will be discarded with the new UI (that already don't use vlc_object foo anymore). 

On Sun, Mar 17, 2019, at 10:57, Rémi Denis-Courmont wrote:
> ---
>  modules/gui/qt/menus.hpp | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/modules/gui/qt/menus.hpp b/modules/gui/qt/menus.hpp
> index ca24c5f8e3..fc660562f7 100644
> --- a/modules/gui/qt/menus.hpp
> +++ b/modules/gui/qt/menus.hpp
> @@ -44,8 +44,6 @@ public:
>                    vlc_value_t _val, const char *_var ) : QObject( parent )
>      {
>          this->obj = obj;
> -        if( obj )
> -            vlc_object_hold( &*obj );
>          i_val_type = _i_type;
>          val = _val;
>          psz_var = strdup( _var );
> @@ -55,8 +53,6 @@ public:
>          free( psz_var );
>          if( ( i_val_type & VLC_VAR_TYPE) == VLC_VAR_STRING )
>              free( val.psz_string );
> -        if( obj )
> -            vlc_object_release( &*obj );
>      }
>  
>      QVLCObject obj;
> -- 
> 2.20.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel