[vlc-devel] [PATCH] Fix double free in stream deletion

Awais Chishti chishtiawais511 at gmail.com
Wed Mar 20 15:45:49 CET 2019


Hi,
Can you please specify whether you're saying that the crash is impossible
or that the workaround can not be implemented
I'm new to the code so it isn't explanatory from your reason

On Wed, Mar 20, 2019 at 7:32 PM Francois Cartegnie <fcartegnie at gmail.com>
wrote:

> Le 20/03/2019 à 18:08, chishtiawais511 at gmail.com a écrit :
> > From: Awais Chishti <chishtiawais511 at gmail.com>
> >
> > Decoder cleaning is being done with module_unneed() once in
> transcode.c:697 and sometimes in the preceeding switch statement causing
> VLC to crash. Either avoid cleaning the decoder in DeleteSoutStreamID() or
> in the transcode_*() functions. The patch does the latter as suggested
> earlier.
> > ---
>
>
> AFAIR that's not possible as the decoder probing must
> copy the resulting format while the decoder is not touching it.
>
>
> --
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190320/091cb920/attachment.html>


More information about the vlc-devel mailing list