[vlc-devel] [PATCH] Fix double free in stream deletion
thomas at gllm.fr
Wed Mar 20 15:51:56 CET 2019
I think you should set p_module and description to NULL for spu and video like it's done for audio.
On Wed, Mar 20, 2019, at 15:46, Awais Chishti wrote:
> Can you please specify whether you're saying that the crash is impossible or that the workaround can not be implemented
> I'm new to the code so it isn't explanatory from your reason
> On Wed, Mar 20, 2019 at 7:32 PM Francois Cartegnie <fcartegnie at gmail.com> wrote:
>> Le 20/03/2019 à 18:08, chishtiawais511 at gmail.com a écrit :
>> > From: Awais Chishti <chishtiawais511 at gmail.com>
>> > Decoder cleaning is being done with module_unneed() once in transcode.c:697 and sometimes in the preceeding switch statement causing VLC to crash. Either avoid cleaning the decoder in DeleteSoutStreamID() or in the transcode_*() functions. The patch does the latter as suggested earlier.
>> > ---
>> AFAIR that's not possible as the decoder probing must
>> copy the resulting format while the decoder is not touching it.
>> Francois Cartegnie
>> VideoLAN - VLC Developer
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel