[vlc-devel] [PATCH] Fix double free in stream deletion

Francois Cartegnie fcartegnie at gmail.com
Wed Mar 27 08:45:58 CET 2019


Le 27/03/2019 à 11:34, Awais Chishti a écrit :
> 
> Can someone please revisit this patch? The problem it solves is crashing important features. Some discussion was done earlier but there was no final decision. Thursday, 21 March 2019, 08:08PM +05:00 from Francois Cartegnie  fcartegnie at gmail.com :

As I said below, cleaning the fmt does not seem correct to me and is
likely to break transcoding cases (and I doubt you fully tested
transcoding combinations).

To me, the initial fix was correct.

>>
>> We copy fmt_in or fmt_out for info we need late, after the decoder chain
>> is created in transcode test steps, after start/stopping the decoder/chain.
>>
>> This needs to be compared to behavior before transcode split/refactoring
>>


-- 
Francois Cartegnie
VideoLAN - VLC Developer


More information about the vlc-devel mailing list