[vlc-devel] [PATCH] Fix double free in stream deletion
thomas at gllm.fr
Wed Mar 27 08:55:01 CET 2019
On Wed, Mar 27, 2019, at 08:46, Francois Cartegnie wrote:
> Le 27/03/2019 à 11:34, Awais Chishti a écrit :
> > Can someone please revisit this patch? The problem it solves is crashing important features. Some discussion was done earlier but there was no final decision. Thursday, 21 March 2019, 08:08PM +05:00 from Francois Cartegnie fcartegnie at gmail.com :
Opps sorry, I merged it before reading your last review.
> As I said below, cleaning the fmt does not seem correct to me and is
> likely to break transcoding cases (and I doubt you fully tested
> transcoding combinations).
> To me, the initial fix was correct.
I double checked, everything seems correct:
The decoder is already cleaned once in DeleteSoutStreamID() that is always excecuted after transcode_audio_clean / transcode_video_clean / transcode_spu_clean.
> >> We copy fmt_in or fmt_out for info we need late, after the decoder chain
> >> is created in transcode test steps, after start/stopping the decoder/chain.
> >> This needs to be compared to behavior before transcode split/refactoring
> Francois Cartegnie
> VideoLAN - VLC Developer
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel