[vlc-devel] [PATCH 2/2] network: tls: Handle errors from older kernels

[Hugo Beauzée-Luyssen]

On Fri, Mar 29, 2019, at 1:22 PM, Rémi Denis-Courmont wrote:
> EPIPE is emitted when the socket gets connected then disconnected 
> (since VLC blocks SIGPIPE). In that case, it is not correct and 
> potentially dangerous to reconnect and resend anything.
> 
> This patch looks very wrong.
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

If this was in vlc_tls_SocketWrite I'd totally agree, but in vlc_tls_ConnectWrite, where the connection was not established yet, it seems OK to me, as we would connect, not reconnect.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr