[vlc-devel] [PATCH 2/2] network: tls: Handle errors from older kernels

[Rémi Denis-Courmont]

It sounds to me that this relies on a race condition (to not occur) ?

Le 29 mars 2019 14:31:50 GMT+02:00, "Hugo Beauzée-Luyssen" <hugo at beauzee.fr> a écrit :
>On Fri, Mar 29, 2019, at 1:22 PM, Rémi Denis-Courmont wrote:
>> EPIPE is emitted when the socket gets connected then disconnected 
>> (since VLC blocks SIGPIPE). In that case, it is not correct and 
>> potentially dangerous to reconnect and resend anything.
>> 
>> This patch looks very wrong.
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser 
>> ma brièveté. 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>If this was in vlc_tls_SocketWrite I'd totally agree, but in
>vlc_tls_ConnectWrite, where the connection was not established yet, it
>seems OK to me, as we would connect, not reconnect.
>
>-- 
>  Hugo Beauzée-Luyssen
>  hugo at beauzee.fr
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190329/232ff061/attachment.html>