[vlc-devel] [PATCH 2/2] network: tls: Handle errors from older kernels

Hugo Beauzée-Luyssen hugo at beauzee.fr
Fri Mar 29 14:31:34 CET 2019


On Fri, Mar 29, 2019, at 2:04 PM, Rémi Denis-Courmont wrote:
> It sounds to me that this relies on a race condition (to not occur) ?
> 

As far as I can see the documentation mentions that it's the caller responsibility to have a thread performing a send before a recv if fast open is used.
Regarding send, AFAICS the current code assumes a single sender thread, since the vlc_tls_operations pointer is updated non-atomically in vlc_tls_ConnectWrite

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr


More information about the vlc-devel mailing list