[vlc-devel] [PATCH 02/10] Add secondary property to decoder

[Jean-Baptiste Kempf]

On Tue, 7 May 2019, at 06:56, Roland Bewick wrote:
> 
> On 6/05/2019 2:40 PM, Thomas Guillem wrote:
> >
> > On Sun, May 5, 2019, at 12:03, Roland Bewick wrote:
> >> to control the alignment, margin and synchronization of subpictures
> >> ---
> >>   include/vlc_subpicture.h |  1 +
> >>   src/input/decoder.c      | 14 ++++++++++++++
> >>   src/input/decoder.h      |  7 +++++++
> >>   src/input/es_out.c       |  3 +++
> >>   4 files changed, 25 insertions(+)
> >>
> >> diff --git a/include/vlc_subpicture.h b/include/vlc_subpicture.h
> >> index ea618e8aa1..d36ed2c055 100644
> >> --- a/include/vlc_subpicture.h
> >> +++ b/include/vlc_subpicture.h
> >> @@ -192,6 +192,7 @@ struct subpicture_t
> >>        * subtitle type. */
> >>       /**@{*/
> >>       bool         b_subtitle;            /**< the picture is a movie subtitle */
> >> +    bool         b_secondary;           /**< use secondary subtrack settings */
> > What about using an unsigned here ?
> > 1 = main
> > 2 = secondary
> >
> > That way, we won't have to modify again if we handle 3 SPUS.
> 
> That does feel a bit cleaner. I'll see what else I can change in that 
> regard (Without over-engineering - I'll leave the GUI / configuration / 
> VLC vars as is).

Technically, with checkboxes, you can have 3 :D 
-- 
Jean-Baptiste Kempf -  President
+33 672 704 734