[vlc-devel] [PATCH 02/10] Add secondary property to decoder

[Roland Bewick]

On 7/05/2019 1:24 PM, Jean-Baptiste Kempf wrote:

>
> On Tue, 7 May 2019, at 06:56, Roland Bewick wrote:
>> On 6/05/2019 2:40 PM, Thomas Guillem wrote:
>>> On Sun, May 5, 2019, at 12:03, Roland Bewick wrote:
>>>> to control the alignment, margin and synchronization of subpictures
>>>> ---
>>>>    include/vlc_subpicture.h |  1 +
>>>>    src/input/decoder.c      | 14 ++++++++++++++
>>>>    src/input/decoder.h      |  7 +++++++
>>>>    src/input/es_out.c       |  3 +++
>>>>    4 files changed, 25 insertions(+)
>>>>
>>>> diff --git a/include/vlc_subpicture.h b/include/vlc_subpicture.h
>>>> index ea618e8aa1..d36ed2c055 100644
>>>> --- a/include/vlc_subpicture.h
>>>> +++ b/include/vlc_subpicture.h
>>>> @@ -192,6 +192,7 @@ struct subpicture_t
>>>>         * subtitle type. */
>>>>        /**@{*/
>>>>        bool         b_subtitle;            /**< the picture is a movie subtitle */
>>>> +    bool         b_secondary;           /**< use secondary subtrack settings */
>>> What about using an unsigned here ?
>>> 1 = main
>>> 2 = secondary
>>>
>>> That way, we won't have to modify again if we handle 3 SPUS.
>> That does feel a bit cleaner. I'll see what else I can change in that
>> regard (Without over-engineering - I'll leave the GUI / configuration /
>> VLC vars as is).
> Technically, with checkboxes, you can have 3 :D


Yes, but do you feel like this is going to be something that many people 
will actually use? or just introduce more complexity than is required?

I'm actively learning a language and I find it useful to show both my 
native and target language subs. I also understand if you have a 
friend/partner who speaks language A, you speak language B, and you're 
watching a movie together in language C. This, I think, was the original 
goal.

But beyond that, maybe you have a group of people with no common shared 
language all wanting to watch a video together.

I guess the majority of the complexity introduced will be for me, mostly 
related to the GUI. If we supported configuring the N subtitles through 
hotkeys I believe it'd be fairly trivial but I don't think that's enough.

There's a lot that could be added beyond simply "dual subtitle support". 
I think we need to draw a line where the original task ends and decide 
what is actually necessary for the majority of the users who are 
interested in this feature.

Roland