[vlc-devel] [vlc-commits] vout: add vout_Pause

Rémi Denis-Courmont remi at remlab.net
Sun May 12 09:56:46 CEST 2019


Le samedi 11 mai 2019, 17:58:06 EEST Thomas Guillem a écrit :
> On Sat, May 11, 2019, at 09:13, Rémi Denis-Courmont wrote:
> > Le vendredi 10 mai 2019, 10:51:27 EEST Thomas Guillem a écrit :
> > > vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Mon May  6
> > > 17:45:37 2019 +0200| [be5856e51f84237c7008c1ea9385be2b0b28d849] |
> > > committer: Thomas Guillem
> > > 
> > > vout: add vout_Pause
> > > 
> > > vout_Pause will clean variables that are used by the current owner
> > > (clock,
> > > mouse) and put the vout to sleep.
> > 
> > What for? AFAICT, that'sexactly what vout_StopDisplay() does already. It
> > just needs to be exposed.
> 
> But it will stop the vd plugin. You don't want that when you recycle the
> same vout (window + vd) in case two video with same chrpma/size are played
> in a raw.

I fail to see a use case for recycling the display. The code was in place to 
reuse the window, possibly resizing it, and you just broke all that without 
any discussion.

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list