[vlc-devel] [vlc-commits] vout: add vout_Pause

[Thomas Guillem]

On Sun, May 12, 2019, at 09:56, Rémi Denis-Courmont wrote:
> Le samedi 11 mai 2019, 17:58:06 EEST Thomas Guillem a écrit :
> > On Sat, May 11, 2019, at 09:13, Rémi Denis-Courmont wrote:
> > > Le vendredi 10 mai 2019, 10:51:27 EEST Thomas Guillem a écrit :
> > > > vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Mon May  6
> > > > 17:45:37 2019 +0200| [be5856e51f84237c7008c1ea9385be2b0b28d849] |
> > > > committer: Thomas Guillem
> > > > 
> > > > vout: add vout_Pause
> > > > 
> > > > vout_Pause will clean variables that are used by the current owner
> > > > (clock,
> > > > mouse) and put the vout to sleep.
> > > 
> > > What for? AFAICT, that'sexactly what vout_StopDisplay() does already. It
> > > just needs to be exposed.
> > 
> > But it will stop the vd plugin. You don't want that when you recycle the
> > same vout (window + vd) in case two video with same chrpma/size are played
> > in a raw.
> 
> I fail to see a use case for recycling the display. The code was in place to 
> reuse the window, possibly resizing it, and you just broke all that without 
> any discussion.

I proposed the vout pause patch one week ago, cf. "[PATCH 00/20] MR: Finishing vout life cycle work"
I agree reviewing a big a patch set like this one is confusing. Can't wait for true merge requests on gitlab.

You don't want to recycle the same VD plugin when the second video has exactly the same size + chroma ? (Because you also break it without any discussion).

> 
> -- 
> Rémi Denis-Courmont
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel