[vlc-devel] [PATCH 01/15] Enable selection of secondary SPU ES in the core

[Thomas Guillem]

The new way to select multiple tracks should be more generic since it could possibly work for video and audio (in the future).

The player API is new and was not yet published, we can modify it easily.

We could just add a "bool multiple" to vlc_player_SelectTrack(); and specify in the documentation that multiple work only for Video and for 2 subtitles.

Or we can find a new function, like vlc_player_SelectTrackMultiple().

On Tue, May 14, 2019, at 19:42, Roland Bewick wrote:
> 
> 
> On Wed, 15 May 2019 at 12:02 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
>> Le tiistaina 14. toukokuuta 2019, 12.40.00 EEST Roland Bewick a écrit :
>>  > ---
>>  > include/vlc_player.h | 13 +++++++++++++
>>  > src/input/es_out.c | 47
>>  > ++++++++++++++++++++++++++++++++++++++++++++-- src/input/es_out.h |
>>  > 5 ++++-
>>  > src/input/input.c | 5 +++++
>>  > src/input/input_internal.h | 1 +
>>  > src/input/player.c | 11 +++++++++++
>>  > src/libvlccore.sym | 1 +
>>  > 7 files changed, 80 insertions(+), 3 deletions(-)
>>  > 
>>  > diff --git a/include/vlc_player.h b/include/vlc_player.h
>>  > index 1aa5f8e687..077b3883ad 100644
>>  > --- a/include/vlc_player.h
>>  > +++ b/include/vlc_player.h
>>  > @@ -2428,6 +2428,19 @@ VLC_API unsigned
>>  > vlc_player_GetSubtitleTextScale(vlc_player_t *player);
>>  > 
>>  > /**
>>  > + * Allow secondary subtitle track(s) to be selected when
>>  > + * the primary subtitle track is already selected.
>>  > + *
>>  > + * @note This must be returned to false immediately after
>>  > + * selection of the subtitle.
>> 
>>  No - that won't work because you cannot assume atomicity of the following 
>>  operations on the ES output , at least not with the following code.
> 
> You’re correct, but the possibility of unwanted ES selection occuring in actual use is negligible.
> 
> 
> 
>> 
>> 
>> 
>> --
>>  Реми Дёни-Курмон
>> http://www.remlab.net/
>> 
>> 
>> 
>>  _______________________________________________
>>  vlc-devel mailing list
>>  To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190515/694fc91a/attachment.html>