[vlc-devel] [PATCH 03/16] Add variable to enable/disable dual subtitles

[Roland Bewick]

So the state has to be linked across the interfaces. In this case shouldn’t
it belong to the player? If not, where?

I like Thomas’ idea: Store the bool in the vlc_player_t struct.

Roland

On Mon, 27 May 2019 at 11:53 PM, Rémi Denis-Courmont <remi at remlab.net>
wrote:

> Le maanantaina 27. toukokuuta 2019, 10.19.43 EEST Thomas Guillem a écrit :
> > Hello,
> >
> > This should not belong to the player.
> > I think you should store the internal dual subtitle state in each
> > interfaces.
>
> Yes and I wrote something to same effect in a previous review.
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190528/e9dd1abb/attachment.html>