[vlc-devel] [PATCH 03/16] Add variable to enable/disable dual subtitles

[Rémi Denis-Courmont]

This belongs in the UI, not the player as I explained in a previous review.

Le 28 mai 2019 05:06:54 GMT+03:00, Roland Bewick <roland.bewick at gmail.com> a écrit :
>So the state has to be linked across the interfaces. In this case
>shouldn’t
>it belong to the player? If not, where?
>
>I like Thomas’ idea: Store the bool in the vlc_player_t struct.
>
>Roland
>
>On Mon, 27 May 2019 at 11:53 PM, Rémi Denis-Courmont <remi at remlab.net>
>wrote:
>
>> Le maanantaina 27. toukokuuta 2019, 10.19.43 EEST Thomas Guillem a
>écrit :
>> > Hello,
>> >
>> > This should not belong to the player.
>> > I think you should store the internal dual subtitle state in each
>> > interfaces.
>>
>> Yes and I wrote something to same effect in a previous review.
>>
>> --
>> Rémi Denis-Courmont
>> http://www.remlab.net/
>>
>>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190528/d12a79c6/attachment.html>