[vlc-devel] [PATCH] qt:soutchain: fix compilation with Clang 9

Steve Lhomme robux4 at ycbcr.xyz
Mon Nov 4 12:11:37 CET 2019


x86_64-w64-mingw32/include/QtCore/qlist.h:444:35: error: object of type 'SoutModule' cannot be assigned because its copy assignment operator is implicitly deleted
    else *reinterpret_cast<T*>(n) = t;
                                  ^
x86_64-w64-mingw32/include/QtCore/qlist.h:587:13: note: in instantiation of member function 'QList<SoutModule>::node_construct' requested here
            node_construct(n, t);
            ^
modules/gui/qt/util/soutchain.hpp:121:17: note: in instantiation of member function 'QList<SoutModule>::append' requested here
        modules.append( SoutModule( module ) );
                ^
modules/gui/qt/util/soutchain.hpp:48:19: note: copy assignment operator of 'SoutModule' is implicitly deleted because field 'moduleName' has no copy assignment operator
    const QString moduleName;
                  ^
4 warnings and 1 error generated.
---
 modules/gui/qt/util/soutchain.hpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/modules/gui/qt/util/soutchain.hpp b/modules/gui/qt/util/soutchain.hpp
index 2bfac377643..c593738e0db 100644
--- a/modules/gui/qt/util/soutchain.hpp
+++ b/modules/gui/qt/util/soutchain.hpp
@@ -45,7 +45,7 @@ public:
 private:
     typedef QPair<QString, SoutOption> OptionPairType;
     typedef QList<OptionPairType> OptionsType;
-    const QString moduleName;
+    QString moduleName;
     OptionsType options;
 };
 
@@ -81,9 +81,9 @@ public:
 
 private:
     enum Kind{ String, Nested };
-    const Kind kind;
-    const QString stringValue;
-    const SoutModule nestedModule;
+    Kind kind;
+    QString stringValue;
+    SoutModule nestedModule;
 };
 
 
-- 
2.17.1



More information about the vlc-devel mailing list