[vlc-devel] [PATCH] qt:soutchain: fix compilation with Clang 9

[Alexandre Janniaux]

Hi,

Maybe the commit message can be more explicit about what is the real
issue and how it is fixed. Otherwise, LGTM.

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, Nov 04, 2019 at 12:11:37PM +0100, Steve Lhomme wrote:
> x86_64-w64-mingw32/include/QtCore/qlist.h:444:35: error: object of type 'SoutModule' cannot be assigned because its copy assignment operator is implicitly deleted
>     else *reinterpret_cast<T*>(n) = t;
>                                   ^
> x86_64-w64-mingw32/include/QtCore/qlist.h:587:13: note: in instantiation of member function 'QList<SoutModule>::node_construct' requested here
>             node_construct(n, t);
>             ^
> modules/gui/qt/util/soutchain.hpp:121:17: note: in instantiation of member function 'QList<SoutModule>::append' requested here
>         modules.append( SoutModule( module ) );
>                 ^
> modules/gui/qt/util/soutchain.hpp:48:19: note: copy assignment operator of 'SoutModule' is implicitly deleted because field 'moduleName' has no copy assignment operator
>     const QString moduleName;
>                   ^
> 4 warnings and 1 error generated.
> ---
>  modules/gui/qt/util/soutchain.hpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/modules/gui/qt/util/soutchain.hpp b/modules/gui/qt/util/soutchain.hpp
> index 2bfac377643..c593738e0db 100644
> --- a/modules/gui/qt/util/soutchain.hpp
> +++ b/modules/gui/qt/util/soutchain.hpp
> @@ -45,7 +45,7 @@ public:
>  private:
>      typedef QPair<QString, SoutOption> OptionPairType;
>      typedef QList<OptionPairType> OptionsType;
> -    const QString moduleName;
> +    QString moduleName;
>      OptionsType options;
>  };
>
> @@ -81,9 +81,9 @@ public:
>
>  private:
>      enum Kind{ String, Nested };
> -    const Kind kind;
> -    const QString stringValue;
> -    const SoutModule nestedModule;
> +    Kind kind;
> +    QString stringValue;
> +    SoutModule nestedModule;
>  };
>
>
> --
> 2.17.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel