[vlc-devel] [PATCH] test: hxxx: fix potentially uninitialized variable warnings

[Alexandre Janniaux]

Hi,

Sorry I forgot this comment and it was merged.

Yes, but the compiler doesn't know this and the fact that b1/b2 is
not used afterwards doesn't remove the warning. I hope it's enough
to justify the patch.

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, Oct 28, 2019 at 07:24:06AM +0100, Steve Lhomme wrote:
> On 2019-10-26 14:17, Alexandre Janniaux wrote:
> > ---
> >   test/modules/packetizer/hxxx.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/test/modules/packetizer/hxxx.c b/test/modules/packetizer/hxxx.c
> > index 6a7767570f..8cae9bfd86 100644
> > --- a/test/modules/packetizer/hxxx.c
> > +++ b/test/modules/packetizer/hxxx.c
> > @@ -62,6 +62,10 @@ static void test_iterators( const uint8_t *p_ab, size_t i_ab, /* AnnexB */
> >           int i_nal = 0;
> >           while(b1 && b2)
> >           {
> > +            /* hxxx_*_iterate_next can potentially not set these pointers. */
>
> Yes, but in this case b1/b2 is false and the value is not used.
>
> > +            p_start_ab = NULL;
> > +            p_start_prefix = NULL;
> > +
> >               b1 = hxxx_annexb_iterate_next( &it_ab, &p_start_ab, &i_size_ab );
> >               b2 = hxxx_iterate_next( &it_prefix, &p_start_prefix, &i_size_prefix );
> >               printf("NAL %d ", i_nal++);
> > --
> > 2.23.0
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> >
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel