[vlc-devel] [PATCH] test: hxxx: fix potentially uninitialized variable warnings

[Rémi Denis-Courmont]

Yeah. This patch does not look right.

Don't confuse unitialised (a bug) with maybe unitialised (often not a bug).

Le 28 octobre 2019 15:24:06 GMT+09:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 2019-10-26 14:17, Alexandre Janniaux wrote:
>> ---
>>   test/modules/packetizer/hxxx.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>> 
>> diff --git a/test/modules/packetizer/hxxx.c
>b/test/modules/packetizer/hxxx.c
>> index 6a7767570f..8cae9bfd86 100644
>> --- a/test/modules/packetizer/hxxx.c
>> +++ b/test/modules/packetizer/hxxx.c
>> @@ -62,6 +62,10 @@ static void test_iterators( const uint8_t *p_ab,
>size_t i_ab, /* AnnexB */
>>           int i_nal = 0;
>>           while(b1 && b2)
>>           {
>> +            /* hxxx_*_iterate_next can potentially not set these
>pointers. */
>
>Yes, but in this case b1/b2 is false and the value is not used.
>
>> +            p_start_ab = NULL;
>> +            p_start_prefix = NULL;
>> +
>>               b1 = hxxx_annexb_iterate_next( &it_ab, &p_start_ab,
>&i_size_ab );
>>               b2 = hxxx_iterate_next( &it_prefix, &p_start_prefix,
>&i_size_prefix );
>>               printf("NAL %d ", i_nal++);
>> -- 
>> 2.23.0
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191109/1d1caa91/attachment.html>