[vlc-devel] [PATCH 09/36] filters: set the input/output video context on video filters

Rémi Denis-Courmont remi at remlab.net
Sat Nov 23 14:43:56 CET 2019


Le torstaina 21. marraskuuta 2019, 16.14.00 EET Steve Lhomme a écrit :
> The input context pushed by the decoder (and soon by the preceding filter in
> chain).
> 
> The output context is similar to the output video video context set by the
> decoder.
> 
> The filter should hold a reference to the output video context and release
> it when it doesn't need it anymore.
> ---
>  include/vlc_filter.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/vlc_filter.h b/include/vlc_filter.h
> index 2979224527d..a26083323ae 100644
> --- a/include/vlc_filter.h
> +++ b/include/vlc_filter.h
> @@ -28,6 +28,8 @@
>  #include <vlc_es.h>
>  #include <vlc_picture.h>
> 
> +typedef struct vlc_video_context  vlc_video_context;

Historically, VLC code style did 'typedef struct FOO_t FOO_t', which clearly 
distinguishes type names from other identifiers. But that violates the C specs. 
So some devs (including me) use just 'struct FOO' without any typedef. I don't 
think we should create a third style.

-- 
レミ・デニ-クールモン
http://www.remlab.net/





More information about the vlc-devel mailing list