[vlc-devel] [PATCH 09/36] filters: set the input/output video context on video filters
robux4 at ycbcr.xyz
Mon Nov 25 10:37:25 CET 2019
On 2019-11-23 14:43, Rémi Denis-Courmont wrote:
> Le torstaina 21. marraskuuta 2019, 16.14.00 EET Steve Lhomme a écrit :
>> The input context pushed by the decoder (and soon by the preceding filter in
>> The output context is similar to the output video video context set by the
>> The filter should hold a reference to the output video context and release
>> it when it doesn't need it anymore.
>> include/vlc_filter.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>> diff --git a/include/vlc_filter.h b/include/vlc_filter.h
>> index 2979224527d..a26083323ae 100644
>> --- a/include/vlc_filter.h
>> +++ b/include/vlc_filter.h
>> @@ -28,6 +28,8 @@
>> #include <vlc_es.h>
>> #include <vlc_picture.h>
>> +typedef struct vlc_video_context vlc_video_context;
> Historically, VLC code style did 'typedef struct FOO_t FOO_t', which clearly
> distinguishes type names from other identifiers. But that violates the C specs.
> So some devs (including me) use just 'struct FOO' without any typedef. I don't
> think we should create a third style.
That ship has sailed when we decided that the video context and video
decide will not have a _t. And we use these typedefs everywhere already
so lines are not unnecessarily long.
More information about the vlc-devel