[vlc-devel] [PATCH 0/6] Fix LibVLC 4 build for Android

[Zhao Zhili]

> On Nov 24, 2019, at 11:19 PM, Alexandre Janniaux <ajanni at videolabs.io> wrote:
> 
> Hi,
> 
> Thank you for the interesting feedback.
> 
> I didn't reproduced the config.rpath issue unfortunately.
> It seems that this file is installed either by autopoint or
> gettextize according to their `info` manual, but is actually
> needed by the lib-link.m4 macros. Can you try adding this to
> the LIBDSM_CONF in contribs/src/libdsm/rules.mak ?
> 
> --disable-rpath
> 
> I currently have no clues why this is happening but I will
> try reproducing on a MacOS machine. I don't even have the
> file on my builds. What is your autotools version ?

I think I found the key to reproduce the issue:

1. with gettext under extras/tools ==> build error
2. clean gettext under extras/tools and 'brew link --force gettext' ==> the problem is gone

The host version gettext is 0.20.1. Not sure whether it's the version or the path that leads to different results.

> 
> I've also made a WIP but working rewrite of the libdsm build
> system with Meson, it could be another candidate for a fix
> but IMHO is not a good candidate currently.
> 
> Regards,
> --
> Alexandre Janniaux
> Videolabs
> 
> On Sun, Nov 24, 2019 at 01:26:16PM +0800, zhilizhao wrote:
>> Hi Alexandre,
>> 
>> After applying your patch set, I can build vlc-android on macOS with arch
>> armeabi-v7a and aarch64 successfully, except one exception: libdsm.
>> 
>> autoreconf: running: automake --add-missing --copy --force-missing
>> configure.ac:28: installing './compile'
>> configure.ac:38: error: required file './config.rpath' not found
>> configure.ac:13: installing './missing'
>> Makefile.am: installing './depcomp'
>> autoreconf: automake failed with exit status: 1
>> make: *** [.libdsm] Error 1
>> 
>> I can bypass the issue by touch config.rpath, but I don’t understand the issue, or
>> what config.rpath is. rpath should not matter for vlc-android since libvlc is a single
>> large shared library loaded directly from Java, I guess.
>> 
>>> On Nov 22, 2019, at 11:07 PM, Alexandre Janniaux <ajanni at videolabs.io> wrote:
>>> 
>>> Hi,
>>> 
>>> The following patchset is fixing some issues depending on the
>>> environment, which arouse when building LibVLC 4 for Android on my
>>> machine and MacOSX machines for example.
>>> 
>>> It fixes CMake toolchain to include the correct flags, and ensure we
>>> have NEON optimization enabled for cmake contribs like soxr and aom.
>>> 
>>> I've tested the patches against all the Android architecture, but given
>>> the compilation time it took, I cannot ensure I don't messed up
>>> something in the process. However they all applied and compiled
>>> atomically without build failure in my tests.
>>> 
>>> The final result is correctly building on every platform on the Gitlab
>>> CI from ePirat repository.
>>> 
>>> Feel free to signal things that are unclear in the commit messages.
>>> 
>>> Regards,
>>> --
>>> Alexandre Janniaux
>>> Videolabs
>>> 
>>> Alexandre Janniaux (6):
>>> contrib: soxr: don't enforce CMAKE_SYSTEM_NAME on android
>>> contrib: aom: cleanup build directory
>>> contrib: aom: conditionnaly enable NEON and set AS_EXECUTABLE
>>> contrib: aom: support android in the build
>>> contrib: main: export ANDROID_API in CFLAGS
>>> contrib: toolchain.cmake: enforce variables for android
>>> 
>>> contrib/src/aom/aom-cmake-android.patch | 51 +++++++++++++++++++++++++
>>> contrib/src/aom/rules.mak               | 15 +++++++-
>>> contrib/src/main.mak                    | 30 +++++++++++++++
>>> contrib/src/soxr/rules.mak              |  3 ++
>>> 4 files changed, 98 insertions(+), 1 deletion(-)
>>> create mode 100644 contrib/src/aom/aom-cmake-android.patch
>>> 
>>> --
>>> 2.24.0
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel