[vlc-devel] [PATCH] configure: fail on casting incompatible pointers

[Steve Lhomme]

On 2019-10-02 14:37, Denis Charmet wrote:
> Hi,
> 
> On 2019-10-02 12:27, Steve Lhomme wrote:
>> On 2019-10-02 12:20, Rémi Denis-Courmont wrote:
>>> And VLC depends on some libraries that rely on bad casts, notably 
>>> libavutil (heap helpers).
>>
>> This is the configure script of VLC, not the contribs. I use this
>> flag all day long on Win32 and Linux builds with no issue. That
>> enables spotting errors like the AMT one very quickly.
>>
> 
> I agree with Rémi here, using it on a small code base is good, using it 
> in something as huge as VLC is more a hassle than anything else 
> especially when you work on embedded platform with crazy broken toolchains.

Except we do not have any contribs with this issue, as I said I've been 
using it for month and it helped a lot.

> And in the end you still have the warning to spot the errors.

Just like the commit that was pushed yesterday with a warning.

Warnings are precisely useless because we have a huge codebase. When 
building VLC there's way too much noise to actually see the good ones.

And this particular type of warning is pointing out very risky code that 
should be fixed ASAP.