[vlc-devel] [PATCH] contrib: unexport env variables when cross-compiling

[Rémi Denis-Courmont]

Le torstaina 3. lokakuuta 2019, 18.57.53 EEST Alexandre Janniaux a écrit :
> Hi,
> 
> I think you missed the whole point of my argument. I might not have been
> clear enough, so let me rephrase it with yours:
> 
> The point is not that __all__ special variables, which by your definition
> is equal to the set of variables used by the underlying tools, need to be
> escaped.
> 
> The focus is more on variables that are __already__ taken into account by
> the underlying buildsystem, which are the HOSTVARS, as stated by the commit
> message of Marvin.

HOSTVARS are *not* exported, and thus, they don't need to be unexported. 
Otherwise, HOSTVARS would be entirely pointless.
This is literally from the original main:mak:

----8<----
EXTRA_CFLAGS += -I$(PREFIX)/include
CPPFLAGS := $(CPPFLAGS) $(EXTRA_CFLAGS)
CFLAGS := $(CFLAGS) $(EXTRA_CFLAGS)
CXXFLAGS := $(CXXFLAGS) $(EXTRA_CFLAGS)
EXTRA_LDFLAGS += -L$(PREFIX)/lib
LDFLAGS := $(LDFLAGS) $(EXTRA_LDFLAGS)
# Do not export those! Use HOSTVARS.
---->8----

-- 
Реми Дёни-Курмон
http://www.remlab.net/