[vlc-devel] [PATCH] contrib: unexport env variables when cross-compiling
ajanni at videolabs.io
Thu Oct 3 18:50:58 CEST 2019
That we agree, I know the main.mak quite well, but I'm not sure what your
point on this is and how what you're saying is solving this semantic issue.
Can you expand it more clearly ?
>From my point of view, there are only two ways:
+ define a correct semantic for CC/CXX/CFLAGS/etc and apply it. That's my
point in the previous mails and what epirat is achieving here. It means
that the contrib make is a build system of itself and do the correct
behaviour based on these variables (they are its input). Unsetting them
is an implementation detail coming from the fact it's forking with the
+ avoid ever using CC/CXX/CFLAGS as environment variable with contribs.
Then it must be documented which is not the case currently either, and
unsetting them wouldn't be incorrect as you know in which environment
your subcommands are supposed to run.
Both solutions are correct but it has to be clearly define __now__ so the
current semantic issue is solved. Can you highlight what you'd like it to
be so the real issue in this thread can be addressed ?
On Thu, Oct 03, 2019 at 07:14:10PM +0300, Rémi Denis-Courmont wrote:
> Le torstaina 3. lokakuuta 2019, 18.57.53 EEST Alexandre Janniaux a écrit :
> > Hi,
> > I think you missed the whole point of my argument. I might not have been
> > clear enough, so let me rephrase it with yours:
> > The point is not that __all__ special variables, which by your definition
> > is equal to the set of variables used by the underlying tools, need to be
> > escaped.
> > The focus is more on variables that are __already__ taken into account by
> > the underlying buildsystem, which are the HOSTVARS, as stated by the commit
> > message of Marvin.
> HOSTVARS are *not* exported, and thus, they don't need to be unexported.
> Otherwise, HOSTVARS would be entirely pointless.
> This is literally from the original main:mak:
> EXTRA_CFLAGS += -I$(PREFIX)/include
> CPPFLAGS := $(CPPFLAGS) $(EXTRA_CFLAGS)
> CFLAGS := $(CFLAGS) $(EXTRA_CFLAGS)
> CXXFLAGS := $(CXXFLAGS) $(EXTRA_CFLAGS)
> EXTRA_LDFLAGS += -L$(PREFIX)/lib
> LDFLAGS := $(LDFLAGS) $(EXTRA_LDFLAGS)
> # Do not export those! Use HOSTVARS.
> Реми Дёни-Курмон
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel