[vlc-devel] [PATCH 01/39] video_output: pass the video format to vout_SizeWindow()

Alexandre Janniaux ajanni at videolabs.io
Mon Oct 7 13:51:12 CEST 2019


On Mon, Oct 07, 2019 at 02:09:55PM +0300, Rémi Denis-Courmont wrote:
> Hello,
> This contradicts both the definition of zoom, auto-scale and other parameters,

If it happens that it contradicts zoom/auto-scale or other
parameters, I would rather choose to change their definition
which is confusing anyway with rendering API and an edge
case of usage in VLC, than prevent a full vout reuse which
correspond to the smoothest nominal usage of VLC player.

> and contradicts earlier discussion about window resize policy here.

I think I made at least half of the discussion on this but
can't see the contradiction, or even the link between the
unimplemented synchronization for smooth resizing and the
fact that input format for a vout can change.

Even if you keep destroying the vout to recreate it, I fail
to see how this change anything related to resizing too.
Can you detail what is bothering you?

> So nack.

The point is about finding a clean way to implement Steve's
features. It is pivotal in the design of video output so it
can impede other work like maybe the synchronous resize
design you had in mind, so the goal is to explain what you
need its design to take into account if you don't want to
modify and suggest it yourself later, not prevent code from
being merged. It is all about saving contributor's free
time for later. I hope we can be cooperative on this
mailing for the good of everyone.

Alexandre Janniaux

> Le 7 octobre 2019 10:33:58 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
> >On 2019-10-03 20:42, Rémi Denis-Courmont wrote:
> >> Le keskiviikkona 2. lokakuuta 2019, 17.23.16 EEST Steve Lhomme a
> >écrit :
> >>> This will be needed when the GetDevice call will create a window
> >without
> >>> setting the sys->original which is only related to the display
> >module.
> >>
> >> sys->original is the "input" format to the video output. I don't see
> >what else
> >> the vout window can use as the basis for size computation. In fact,
> >anything
> >> else would violate the existing definitions for the concerned
> >configuration
> >> parameters, AFAICT.
> >
> >The patch comment says "the sys->original which is only related to the
> >display module". In other words it's not useful to the window creation.
> >
> >The sys->original will only be set/used with the display module, not
> >the
> >window module.
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel
> --
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list