[vlc-devel] [PATCH 01/39] video_output: pass the video format to vout_SizeWindow()

[Rémi Denis-Courmont]

Hi,

Zoom means that the initial size is zoom times the video format. So it does need the format as input. And you can't create a window of 0x0, but even if you could , it would be disastrous for UX.

Le 7 octobre 2019 14:27:42 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 2019-10-07 13:09, Rémi Denis-Courmont wrote:
>> Hello,
>> 
>> This contradicts both the definition of zoom, auto-scale and other 
>> parameters, and contradicts earlier discussion about window resize 
>> policy here.
>
>Not at all. The format is only used by the window to get an initial 
>size. We might even create it with no format at all, using 0x0 or any 
>default size (or let the window parent decide).
>
>The zoom and autoscale are just ways to change the window size based on
>
>the input video format parameters. That doesn't mean to say that the 
>video format has to be passed to the window at all.
>
>> So nack.
>
>So no.
>
>> Le 7 octobre 2019 10:33:58 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz>
>a 
>> écrit :
>> 
>>     On 2019-10-03 20:42, Rémi Denis-Courmont wrote:
>> 
>>         Le keskiviikkona 2. lokakuuta 2019, 17.23.16 EEST Steve
>Lhomme a
>>         écrit :
>> 
>>             This will be needed when the GetDevice call will create a
>>             window without
>>             setting the sys->original which is only related to the
>>             display module.
>> 
>>         sys->original is the "input" format to the video output. I
>don't
>>         see what else
>>         the vout window can use as the basis for size computation. In
>>         fact, anything
>>         else would violate the existing definitions for the concerned
>>         configuration
>>         parameters, AFAICT.
>> 
>> 
>>     The patch comment says "the sys->original which is only related
>to the
>>     display module". In other words it's not useful to the window
>creation.
>>     The sys->original will only be set/used with the display module,
>not the
>>     window module.
>>    
>------------------------------------------------------------------------
>>     vlc-devel mailing list
>>     To unsubscribe or modify your subscription options:
>>     https://mailman.videolan.org/listinfo/vlc-devel
>> 
>> 
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser 
>> ma brièveté.
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191007/4c9c4838/attachment.html>