[vlc-devel] [PATCH 3/4] skiptags: Don't activate on preparse

[Rémi Denis-Courmont]

Le tiistaina 8. lokakuuta 2019, 19.16.16 EEST Hugo Beauzée-Luyssen a écrit :
> ---
>  modules/stream_filter/skiptags.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/modules/stream_filter/skiptags.c
> b/modules/stream_filter/skiptags.c index 1097fc2764..3fdce9a94f 100644
> --- a/modules/stream_filter/skiptags.c
> +++ b/modules/stream_filter/skiptags.c
> @@ -198,6 +198,9 @@ static int Open(vlc_object_t *obj)
>      block_t *p_tags = NULL, *p_tag = NULL;
>      unsigned i_tagscount = 0;
> 
> +    if (stream->b_preparsing)
> +        return VLC_EGENERIC;

I don't see why. That's going to break filters/demuxers that support preparsing 
bug can't handle the tags. Handling this differently seems very wrong.

-- 
レミ・デニ-クールモン
http://www.remlab.net/