[vlc-devel] [PATCH 3/4] skiptags: Don't activate on preparse

[Hugo Beauzée-Luyssen]

On Tue, Oct 8, 2019, at 7:41 PM, Rémi Denis-Courmont wrote:
> Le tiistaina 8. lokakuuta 2019, 19.16.16 EEST Hugo Beauzée-Luyssen a écrit :
> > ---
> >  modules/stream_filter/skiptags.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/modules/stream_filter/skiptags.c
> > b/modules/stream_filter/skiptags.c index 1097fc2764..3fdce9a94f 100644
> > --- a/modules/stream_filter/skiptags.c
> > +++ b/modules/stream_filter/skiptags.c
> > @@ -198,6 +198,9 @@ static int Open(vlc_object_t *obj)
> >      block_t *p_tags = NULL, *p_tag = NULL;
> >      unsigned i_tagscount = 0;
> > 
> > +    if (stream->b_preparsing)
> > +        return VLC_EGENERIC;
> 
> I don't see why. That's going to break filters/demuxers that support preparsing 

Because preparsing with the tags removed makes taglib's job more complicated, not to say impossible.

I'm not sure there's a way to use a stream_t with the skiptags filter for taglib without inserting another filter that will do the opposite job, since you need to be able to look at both the removed leading tags, and the leftover trailing tags from the same stream.

That, or not using vlc_stream_NewURL

> bug can't handle the tags. Handling this differently seems very wrong.
> 
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr