[vlc-devel] [PATCH 3/9] video_output: add vout_ChangeSource to set a new source for the display

Rémi Denis-Courmont remi at remlab.net
Sat Oct 12 13:35:55 CEST 2019


Le perjantaina 11. lokakuuta 2019, 10.00.18 EEST Steve Lhomme a écrit :
> On 2019-10-10 18:31, Rémi Denis-Courmont wrote:
> > Le torstaina 10. lokakuuta 2019, 17.26.58 EEST Steve Lhomme a écrit :
> >> It may not work, in which case a new display/thread should be created to
> >> handle the new format.
> > 
> > This won't work. The filter chains *must* be restarted so the filters get
> > the correct visible size. And the vout display *should* be restarted so
> > that the display plugins can be probed against the lower resolution.
> 
> You are talking about code I haven't proposed yet.

Yes and no. I'm saying that this function should not be exposed because it 
won't work. The window needs to be reused across stop/start to avoid glitches 
and preserve user size, and thus adding a separate "restart" function is just 
a pointless extra intricacy.

-- 
Реми Дёни-Курмон
http://www.remlab.net/





More information about the vlc-devel mailing list