[vlc-devel] [PATCH 3/9] video_output: add vout_ChangeSource to set a new source for the display

[Thomas Guillem]

On Sat, Oct 12, 2019, at 13:35, Rémi Denis-Courmont wrote:
> Le perjantaina 11. lokakuuta 2019, 10.00.18 EEST Steve Lhomme a écrit :
> > On 2019-10-10 18:31, Rémi Denis-Courmont wrote:
> > > Le torstaina 10. lokakuuta 2019, 17.26.58 EEST Steve Lhomme a écrit :
> > >> It may not work, in which case a new display/thread should be created to
> > >> handle the new format.
> > > 
> > > This won't work. The filter chains *must* be restarted so the filters get
> > > the correct visible size. And the vout display *should* be restarted so
> > > that the display plugins can be probed against the lower resolution.
> > 
> > You are talking about code I haven't proposed yet.
> 
> Yes and no. I'm saying that this function should not be exposed because it 
> won't work. The window needs to be reused across stop/start to avoid glitches 
> and preserve user size, and thus adding a separate "restart" function is just 
> a pointless extra intricacy.

I agree with Rémi here. Let's keep it simple for the beginning.
The window module and the decoder device won't be restarted during the life time of a video track. That's the most important point.

So you will only have to restart the VD plugins and filters.
Let's try first to always restart the VD plugin in case of source change. If later, we see that it take too long time/CPU/glitches, then we could improve it by doing what you want.

> 
> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel