[vlc-devel] [PATCH 04/48] video_output: no need to check if there's a display to Stop in vout_Close
remi at remlab.net
Sat Oct 12 13:41:41 CEST 2019
Le perjantaina 11. lokakuuta 2019, 16.33.18 EEST Steve Lhomme a écrit :
> vout_Close does vout_StopDisplay + vout_DisableWindow
> In the case where there is no display (vout_StopDisplay not called) we
> should still disable the window before destroying it.
At least historically, vout_Stop() would yield an assertion failure if the
display was missing. And that's very much on purpose - to forbid sloppy
programming calling vout_Stop() on an already stopped/not-started vout.
This patch should not work - or something regressed.
More information about the vlc-devel