[vlc-devel] [PATCH 04/48] video_output: no need to check if there's a display to Stop in vout_Close

[Thomas Guillem]

On Sat, Oct 12, 2019, at 13:41, Rémi Denis-Courmont wrote:
> Le perjantaina 11. lokakuuta 2019, 16.33.18 EEST Steve Lhomme a écrit :
> > vout_Close does vout_StopDisplay + vout_DisableWindow
> > 
> > In the case where there is no display (vout_StopDisplay not called) we
> > should still disable the window before destroying it.
> 
> At least historically, vout_Stop() would yield an assertion failure if the 
> display was missing. And that's very much on purpose - to forbid sloppy 
> programming calling vout_Stop() on an already stopped/not-started vout.
> 
> This patch should not work - or something regressed.

Like rémi, I don't think we should have a state where the VD is stopped but the windows is still enabled (except when restarting, cf. vout_Request).

> 
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel