[vlc-devel] [PATCH] smb: try libdsm first

[Alexandre Janniaux]

On Wed, Oct 16, 2019 at 09:25:29PM +0300, Rémi Denis-Courmont wrote:
> Le keskiviikkona 16. lokakuuta 2019, 13.53.57 EEST Thomas Guillem a écrit :
> > On Wed, Oct 16, 2019, at 12:01, Rémi Denis-Courmont wrote:
> With all due respect, I don't think the vlc-devel community does or should
> care (much) about your employer's customers, angry or not. The day all your
> customers will agree with the community is ptobably the day that you have no
> customers left. You are free to deliver an insecure forked version to your
> angry customers if you want.

I'm pretty sure Thomas meant users. Customers as people we're providing support
on the forum. We have patches for Videolabs's customers when they are needed.

> I don't think official VLC releases should be shipped with a known CVE-worth
> security vulnerability, or even that we should slow down network preparsing
> which is already exhibiting enough performance problems as it is.

Maybe there are some other smart (or the opposite) thing we could do to improve
performances, like blacklist for SMBv1? I don't really know SMB but this could
improve performances with regards to the first connection, and we could reset
this whenever SMBv2/3 fails?

Regards,
--
Alexandre Janniaux
Videolabs