[vlc-devel] [PATCH 1/2] input: reduce controls from input_ControlPush

[Thomas Guillem]

Due to a lack of response, I will push this patch tomorrow.


On Wed, Oct 23, 2019, at 08:57, Thomas Guillem wrote:
> ping again,
> 
> I don't see any difference with the previous behavior:
> 
> SEEK(1) SEEK(2) SEEK(3) SET_PROGRAM(1) SET_PROGRAM(2) SEEK(4)
> 
> will be reduced to
> 
> SEEK(3) SET_PROGRAM(2) SEEK(4)
> 
> Same result with or without this patch.
> 
> Could you please tell me what is wrong with this patch ?
> 
> State, Rate, Pos, Time, Program, Title, Seekpoint controls are always 
> been reduced. If you don't want to reduce them anymore, could tell me:
>  - Why ?
>  - Which controls you want to stop reducing
> 
> 
> On Mon, Oct 21, 2019, at 09:59, Thomas Guillem wrote:
> > ping
> > 
> > On Fri, Oct 18, 2019, at 16:07, Thomas Guillem wrote:
> > > 
> > > On Thu, Oct 17, 2019, at 10:28, Francois Cartegnie wrote:
> > > > Le 17/10/2019 à 10:10, Rémi Denis-Courmont a écrit :
> > > > > What François already wrote: you can't reduce time, program, time to time, program.
> > > > > 
> > > > > AFAICT, time, program should reduce to just program, and then program, time is not reducible.
> > > > 
> > > > Not even that case.
> > > > 
> > > > Seek -> new PMT -> new Program -> Selection
> > > > 
> > > > If you remove the seek the program does not exists
> > > > 
> > > > I can't see any possible reduction outside of the really same controls
> > > > sequence.
> > > 
> > > OK, I re-read all answers and I think there is a misunderstanding.
> > > 
> > > 1/ I don't think this commit is changing the previous behavior. If so, 
> > > I missed it, so please tell me where I'm wrong.
> > > 2/ The previous (and new) behavior respect what Francois wants: only 
> > > controls that are the same are reduced.
> > > Example:
> > > 
> > > SEEK SEEK SEEK SET_PROGRAM SSET_PROGRAM SEEK
> > > will be reduced to
> > > 
> > > SEEK SET_PROGRAM SEEK
> > > 
> > > 
> > > > 
> > > > -- 
> > > > Francois Cartegnie
> > > > VideoLAN - VLC Developer
> > > > _______________________________________________
> > > > vlc-devel mailing list
> > > > To unsubscribe or modify your subscription options:
> > > > https://mailman.videolan.org/listinfo/vlc-devel
> > > _______________________________________________
> > > vlc-devel mailing list
> > > To unsubscribe or modify your subscription options:
> > > https://mailman.videolan.org/listinfo/vlc-devel
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel