[vlc-devel] [PATCH 08/16] avcodec: vdpau: do not rely on avctx->refs for VP9

[Rémi Denis-Courmont]

I don't think the misdesigns of the other libavcodec hwaccel are a good reference here. VDPAU hwaccel was designed properly so that the app needs not add codec-specific handling. Not sure about DxVA, but there are no reasons why this would not be possible for VAAPI too, other than that nobody cared to think the design through.

Le 25 octobre 2019 08:45:16 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 2019-10-24 21:21, Rémi Denis-Courmont wrote:
>> Le torstaina 24. lokakuuta 2019, 17.20.22 EEST Steve Lhomme a écrit :
>>> It gives one when it should be 8. Other codecs seem to be OK.
>> 
>> Isn't that a bug in upstream libavcodec ?
>
>It might be. But the ffmpeg hardware handlers and ours except for VDPAU
>
>rely on the codec ID rather than the AVContext refs to find the number 
>of surfaces needed.
>
>At least for VP9 it gives a value of 2 even though 8 are needed. 
>Software decoding works but it might be because it can allocate more 
>pictures than originally expected.
>
>> Forcing 2 refs does not seem to match the patch description.
>
>This also follows other implementations where the default amount needed
>
>is 2 (MPEG1/2, VC1, for example).
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191025/d7a1d8e5/attachment.html>