[vlc-devel] [PATCH] qt: firstrun: remove obsolete warning

Alexandre Janniaux ajanni at videolabs.io
Sat Oct 26 16:26:32 CEST 2019


The configuration file is locked before serialization and the
config_SaveConfigFile can thus be called at multiple places at the same
time.
---
 modules/gui/qt/dialogs/firstrun.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/modules/gui/qt/dialogs/firstrun.cpp b/modules/gui/qt/dialogs/firstrun.cpp
index 4297d15113..a0b9530838 100644
--- a/modules/gui/qt/dialogs/firstrun.cpp
+++ b/modules/gui/qt/dialogs/firstrun.cpp
@@ -44,9 +44,6 @@ void FirstRun::save()
 #endif
     config_PutInt( "qt-privacy-ask", 0 );

-    /* FIXME Should not save here. This will not work as expected if another
-     * plugin overwrote items of its own. */
-#warning FIXME
     /* We have to save here because the user may not launch Prefs */
     config_SaveConfigFile( p_intf );
     close();
--
2.23.0



More information about the vlc-devel mailing list