[vlc-devel] [PATCH] qt: firstrun: remove obsolete warning

[Alexandre Janniaux]

Hi,

Just for the record, for ease to use with non-ML friendly
mail clients, my currently pending patches can be found
there too:

https://github.com/alexandre-janniaux/vlc/commits/pending-patches

I keep it up-to-date so as to add new commits after some
days on the mailing list. I'll re-link the branch when I
do add some to notify again.

Regards,
--
Alexandre Janniaux
Videolabs

On Sat, Oct 26, 2019 at 04:26:32PM +0200, Alexandre Janniaux wrote:
> The configuration file is locked before serialization and the
> config_SaveConfigFile can thus be called at multiple places at the same
> time.
> ---
>  modules/gui/qt/dialogs/firstrun.cpp | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/modules/gui/qt/dialogs/firstrun.cpp b/modules/gui/qt/dialogs/firstrun.cpp
> index 4297d15113..a0b9530838 100644
> --- a/modules/gui/qt/dialogs/firstrun.cpp
> +++ b/modules/gui/qt/dialogs/firstrun.cpp
> @@ -44,9 +44,6 @@ void FirstRun::save()
>  #endif
>      config_PutInt( "qt-privacy-ask", 0 );
>
> -    /* FIXME Should not save here. This will not work as expected if another
> -     * plugin overwrote items of its own. */
> -#warning FIXME
>      /* We have to save here because the user may not launch Prefs */
>      config_SaveConfigFile( p_intf );
>      close();
> --
> 2.23.0
>