[vlc-devel] [PATCH] caopengllayer: do not return an error when crop/zoom/aspect/etc fail

[Marvin Scholz]

On 27 Oct 2019, at 8:07, Rémi Denis-Courmont wrote:

> Le lauantaina 26. lokakuuta 2019, 20.20.41 EET Alexandre Janniaux a 
> écrit :
>> Apple does give a guarantee about not doing things like
>> Do you have any hints that would highlight the fact that
>> that in its backend ?
>
> No, but again, if the error is actually possible under well-defined 
> code, then
> it should be handled properly, and the error handling looks naive at 
> the very
> best.
>
> Unhandlable errors should abort(), e.g. vlc_mutex_init().
>

I agree that if we handle the error, it should be done properly.

In this case I think the only good thing one could do is abort
as that at least gives a somewhat usable trace in crashlogs and
indicates what went wrong. Continuing in a state where we
can’t lock the context would probably lead to very weird behavior
anyway and it does not seem desirable to continue operating in such
a state.

> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel