[vlc-devel] [PATCH] caopengllayer: do not return an error when crop/zoom/aspect/etc fail

[Steve Lhomme]

On 2019-10-27 13:55, Marvin Scholz wrote:
> 
> 
> On 27 Oct 2019, at 8:07, Rémi Denis-Courmont wrote:
> 
>> Le lauantaina 26. lokakuuta 2019, 20.20.41 EET Alexandre Janniaux a 
>> écrit :
>>> Apple does give a guarantee about not doing things like
>>> Do you have any hints that would highlight the fact that
>>> that in its backend ?
>>
>> No, but again, if the error is actually possible under well-defined 
>> code, then
>> it should be handled properly, and the error handling looks naive at 
>> the very
>> best.
>>
>> Unhandlable errors should abort(), e.g. vlc_mutex_init().
>>
> 
> I agree that if we handle the error, it should be done properly.
> 
> In this case I think the only good thing one could do is abort

Crashing is hardly ever a good solution, even more in code used by 
libvlc in a host app. In this case even with a crash report you can look 
at, you'd have no idea why locking the OpenGL context failed.

> as that at least gives a somewhat usable trace in crashlogs and
> indicates what went wrong. Continuing in a state where we
> can’t lock the context would probably lead to very weird behavior
> anyway and it does not seem desirable to continue operating in such
> a state.

The non-crashing way to handle this would be to issue a RESET_PICTURES 
and handle it properly.